Change in osmo-bsc[master]: Return 0 from gsm0408_rcvmsg() if SCCP link is already closed.

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18438 )

Change subject: Return 0 from gsm0408_rcvmsg() if SCCP link is already closed.
......................................................................

Return 0 from gsm0408_rcvmsg() if SCCP link is already closed.

Whether to forward the message or not to an SCCP connection is
an internal question for the GSM 04.08 code. Unlike errors with
the message decoding, memory allocation and other critical errors,
this not an error which should be reported to the caller.
abis_rsl_rx_rll() (the caller) shouldn't know about the message
routing decisions and should only care about actual errors.

This code path is hit in production very often because we frequently
receive a Classmark Change message from a phone right after the MSC
has shut the SCCP connection but before we close the lchan on the BTS.

Change-Id: I2d430ebc894a2345bebaa1841a75e94a3b45eae2
---
M src/osmo-bsc/gsm_04_08_rr.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/gsm_04_08_rr.c b/src/osmo-bsc/gsm_04_08_rr.c
index 586eeab..4e5a307 100644
--- a/src/osmo-bsc/gsm_04_08_rr.c
+++ b/src/osmo-bsc/gsm_04_08_rr.c
@@ -1016,7 +1016,7 @@
 	lchan = msg->lchan;
 	if (!lchan_may_receive_data(lchan)) {
 		LOG_LCHAN(msg->lchan, LOGL_INFO, "Got data in non active state, discarding.\n");
-		return -1;
+		return 0;
 	}
 
 	if (lchan->conn) {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18438
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I2d430ebc894a2345bebaa1841a75e94a3b45eae2
Gerrit-Change-Number: 18438
Gerrit-PatchSet: 3
Gerrit-Owner: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200529/458247c9/attachment.htm>