Change in osmo-bts[master]: bts-trx: vty: Add 'nominal-tx-power' cmd

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri May 29 19:34:54 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18579 )

Change subject: bts-trx: vty: Add 'nominal-tx-power' cmd
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/18579/2/src/osmo-bts-trx/trx_vty.c 
File src/osmo-bts-trx/trx_vty.c:

https://gerrit.osmocom.org/c/osmo-bts/+/18579/2/src/osmo-bts-trx/trx_vty.c@174 
PS2, Line 174: l1h->config.nominal_power_set_by_vty = val ? true : false;
0 dBm may very well be a valid 'nominal power'.  Present-day SDRs often only output something like 4 dBm, so it's not too far fetched that there are some boards the don't do more than 0dBm.

So mplease use an explicit "no ..." command to unset nominal_power_set_by_vty.  And consider even permitting negative values as minimum to this command, lik maybe -10 dBm.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18579
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ib1b6f80d3b54afc42db9d358a79582cc619c6ce4
Gerrit-Change-Number: 18579
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 29 May 2020 19:34:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200529/ef00b58f/attachment.htm>


More information about the gerrit-log mailing list