Change in pysim[master]: ts_31_102.py: add EF_ADF_map

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Fri May 29 10:31:42 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/18564 )

Change subject: ts_31_102.py: add EF_ADF_map
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.osmocom.org/c/pysim/+/18564/1/pySim/cards.py 
File pySim/cards.py:

https://gerrit.osmocom.org/c/pysim/+/18564/1/pySim/cards.py@a228 
PS1, Line 228: '3f00', '2f00'
Are you sure about this change? It's not just '2f00', but with '3f00'.


https://gerrit.osmocom.org/c/pysim/+/18564/1/pySim/ts_31_102.py 
File pySim/ts_31_102.py:

https://gerrit.osmocom.org/c/pysim/+/18564/1/pySim/ts_31_102.py@141 
PS1, Line 141: 'LI': '6F05',
Please align it with tabs:

  EF_ADF_map = {
      'ARR'  : '6F06',
      'IMSI' : '6F07',
      # ...
  }


https://gerrit.osmocom.org/c/pysim/+/18564/1/pySim/ts_51_011.py 
File pySim/ts_51_011.py:

https://gerrit.osmocom.org/c/pysim/+/18564/1/pySim/ts_51_011.py@45 
PS1, Line 45: 
Unrelated change.



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/18564
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I458380bf46b2986662ecdede2551c22cd9be92ba
Gerrit-Change-Number: 18564
Gerrit-PatchSet: 1
Gerrit-Owner: guilly at gmail.com <guilly at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Fri, 29 May 2020 10:31:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200529/07aaa24d/attachment.htm>


More information about the gerrit-log mailing list