This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgHello pespin, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18546 to review the following change. Change subject: pcu/GPRS_Components: send DATA.cnf in f_pcuif_rx_imm_ass() ...................................................................... pcu/GPRS_Components: send DATA.cnf in f_pcuif_rx_imm_ass() The IUT expects a confirmation when Immediate Assignment is sent on PCH. Change-Id: I585a1933dfb2119f1d3223b24db191282fd698b7 --- M pcu/GPRS_Components.ttcn 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/46/18546/1 diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn index a85cd5e..7eff399 100644 --- a/pcu/GPRS_Components.ttcn +++ b/pcu/GPRS_Components.ttcn @@ -196,6 +196,12 @@ } log("Rx Immediate Assignment: ", rr_imm_ass); + + /* Send DATA.cnf back to the IUT (only needed for PCH) */ + if (pcu_msg.u.data_req.sapi == PCU_IF_SAPI_PCH) { + f_pcuif_tx_data_cnf(pcu_msg); + } + setverdict(pass); return true; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18546 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I585a1933dfb2119f1d3223b24db191282fd698b7 Gerrit-Change-Number: 18546 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <axilirator at gmail.com> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200528/51f2591d/attachment.htm>