Change in osmo-remsim[master]: user_simtrace2: Fix typo in frontend_handle_card2modem()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu May 28 14:31:43 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/18543 )

Change subject: user_simtrace2: Fix typo in frontend_handle_card2modem()
......................................................................

user_simtrace2: Fix typo in frontend_handle_card2modem()

this typo was breaking operating with simtrace2 for all responses
that contained more than just a status word.

Change-Id: Id8195d6650c3306e1a39f59d78d1348671ad062d
---
M src/client/user_simtrace2.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved; Verified



diff --git a/src/client/user_simtrace2.c b/src/client/user_simtrace2.c
index 5ce034d..fa6c319 100644
--- a/src/client/user_simtrace2.c
+++ b/src/client/user_simtrace2.c
@@ -339,7 +339,7 @@
 	struct osmo_st2_cardem_inst *ci = bc->cardem;
 	// save SW to our current APDU context
 	ac.sw[0] = data[len-2];
-	ac.sw[1] = data[len=1];
+	ac.sw[1] = data[len-1];
 
 	LOGCI(ci, LOGL_DEBUG, "SIMtrace <= SW=0x%02x%02x, len_rx=%zu\n", ac.sw[0], ac.sw[1], len-2);
 	if (len > 2) { // send PB and data to modem

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/18543
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: Id8195d6650c3306e1a39f59d78d1348671ad062d
Gerrit-Change-Number: 18543
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: Jenkins Builder
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200528/f09bc830/attachment.htm>


More information about the gerrit-log mailing list