Change in osmo-bsc[master]: drop IMSI filter and libfilter completely

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Wed May 27 14:32:14 UTC 2020


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18495 )

Change subject: drop IMSI filter and libfilter completely
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/18495/1/include/osmocom/bsc/osmo_bsc.h 
File include/osmocom/bsc/osmo_bsc.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/18495/1/include/osmocom/bsc/osmo_bsc.h@14 
PS1, Line 14: struct msgb;
> I'm pretty sure we don't need this,and we simply need to include <osmocom/core/msgb. […]
as long as we're using only struct foo* pointers, it is better to declare the struct opaquely than including the entire header file: it reduces dependencies across headers and helps avoid circular includes, and makes compile units smaller; the full header should rather be included only in the .c file whenever possible.

Declaring struct msgb is necessary after removing the bsc_msg_filter.h which brought struct msgb in before.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18495
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I89727af5387e8360362e995fdee959883c37d89a
Gerrit-Change-Number: 18495
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 27 May 2020 14:32:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200527/fd8f373e/attachment.htm>


More information about the gerrit-log mailing list