This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18506 ) Change subject: add TMSI and NRI utility functions for MSC pooling ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/18506/1/src/gsm/gsm23236.c File src/gsm/gsm23236.c: https://gerrit.osmocom.org/c/libosmocore/+/18506/1/src/gsm/gsm23236.c@40 PS1, Line 40: return -1; This is a bit inconsistent with what osmo_tmsi_nri_set() would return in case of an error. Why not return 0xffff? Or given that length constraints are clearly described in doxygen header, you can just OSMO_ASSERT here. Using an out of bounds value is a programming error, not something that should normally happen. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18506 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icb57a2dd9323c7ea11b34003eccc7e68a0247bf5 Gerrit-Change-Number: 18506 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <axilirator at gmail.com> Gerrit-Comment-Date: Wed, 27 May 2020 05:51:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200527/b60a97b0/attachment.htm>