This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18035 ) Change subject: scheduler_trx: fix RSSI calculation for SUB frames ...................................................................... Patch Set 1: (4 comments) > Patch Set 1: Code-Review-1 > > (4 comments) > > Would be also nice to have a more universal solution for all kinds of measurements (+ToA256, +C/I), not only RSSI. Do you think doing this in this patch makes sense? I think it would not be difficult to add this. It would be just the same as with the RSSI. https://gerrit.osmocom.org/c/osmo-bts/+/18035/1/src/osmo-bts-trx/scheduler_trx.c File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/c/osmo-bts/+/18035/1/src/osmo-bts-trx/scheduler_trx.c@1281 PS1, Line 1281: RSSI_FR_LOWER_FOUR > Why only four bursts? A regular TCH/F or FACCH/F frame is interleaved over 8 bursts, so you need to […] The problem is that picking the measurement values becomes a lot more difficult when I compute the average over all 8 samples. The problem is with the SID frames, then suddenly only half of the bursts are sent and recognizing this turned out to be difficult. However, the samples are shifted, so the averaging always sees all bursts and they are averaged once more in the higher layers. I think this has no influence on the final result. https://gerrit.osmocom.org/c/osmo-bts/+/18035/1/src/osmo-bts-trx/scheduler_trx.c@1330 PS1, Line 1330: LOGL_INFO > Unrelated change. Done https://gerrit.osmocom.org/c/osmo-bts/+/18035/1/src/osmo-bts-trx/scheduler_trx.c@1559 PS1, Line 1559: RSSI_HR_MID_TWO > Same question, why only two bursts? It should be 4 for a regular speech frame. (see above) https://gerrit.osmocom.org/c/osmo-bts/+/18035/1/src/osmo-bts-trx/scheduler_trx.c@1617 PS1, Line 1617: LOGL_INFO > Unrelated change. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18035 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I902bb47d68742d2589156f61099b67a0edbaf40b Gerrit-Change-Number: 18035 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Comment-Date: Tue, 26 May 2020 21:08:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <axilirator at gmail.com> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200526/a0d7a39e/attachment.htm>