This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18479 ) Change subject: enb: fix UL max rate calculation ...................................................................... enb: fix UL max rate calculation don't double the maximum rate for UL traffic in MIMO since we are only using MIMO in the downlink Change-Id: I018e8ba8cb822a4bd57b8d0e420dd496172ac229 --- M src/osmo_gsm_tester/obj/enb.py 1 file changed, 4 insertions(+), 5 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo_gsm_tester/obj/enb.py b/src/osmo_gsm_tester/obj/enb.py index 42ff647..9db0d69 100644 --- a/src/osmo_gsm_tester/obj/enb.py +++ b/src/osmo_gsm_tester/obj/enb.py @@ -238,7 +238,7 @@ return self._addr def ue_max_rate(self, downlink=True): - # The max rate for a single UE per PRB configuration in TM1 + # The max rate for a single UE per PRB configuration in TM1 with MCS 28 QAM64 max_phy_rate_tm1_dl = { 6 : 3.5e6, 15 : 11e6, 25 : 18e6, @@ -255,12 +255,11 @@ max_rate = max_phy_rate_tm1_dl[self.num_prb()] else: max_rate = max_phy_rate_tm1_ul[self.num_prb()] + #TODO: calculate for non-standard prb numbers. - if self._txmode > 2: + if downlink and self._txmode > 2: max_rate *= 2 - # We use 3 control symbols for 6, 15 and 25 PRBs which results in lower max rate - if self.num_prb() < 50: - max_rate *= 0.9 + return max_rate # vim: expandtab tabstop=4 shiftwidth=4 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18479 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I018e8ba8cb822a4bd57b8d0e420dd496172ac229 Gerrit-Change-Number: 18479 Gerrit-PatchSet: 3 Gerrit-Owner: srs_andre <andre at softwareradiosystems.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Reviewer: srs_andre <andre at softwareradiosystems.com> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200526/0efcbc8c/attachment.htm>