This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18471 ) Change subject: ms_srs: wait 6s after stopping srsUE ...................................................................... Patch Set 3: Code-Review-1 (1 comment) https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18471/3/src/osmo_gsm_tester/obj/ms_srs.py File src/osmo_gsm_tester/obj/ms_srs.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18471/3/src/osmo_gsm_tester/obj/ms_srs.py@132 PS3, Line 132: MainLoop.sleep(self, self.stop_timeout) I'm sorry to tell you that's not the correct approach, since stop() method is only called by tests whilling to stop the object. The usual process tear down is done by testenv from the process registerd in line 170 ( self.testenv.remember_to_stop(self.process)), where the process object is used directly and it will then call cleanup() method in this class. So the fix is not right. As I said, leave this is as it was and add a boolean flag in stop() or verify_metric(), and sleep in cleanup() only if we didn't already sleep. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18471 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I47e46b8ccce41c9a62d2d6866260d22c927e710d Gerrit-Change-Number: 18471 Gerrit-PatchSet: 3 Gerrit-Owner: srs_andre <andre at softwareradiosystems.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Reviewer: srs_andre <andre at softwareradiosystems.com> Gerrit-Comment-Date: Tue, 26 May 2020 10:38:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200526/9c65dd6c/attachment.htm>