This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
ipse gerrit-no-reply at lists.osmocom.orgipse has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18438 ) Change subject: Return -ENOTCONN from gsm0408_rcvmsg() if SCCP link is already closed. ...................................................................... Patch Set 1: > Patch Set 1: > > I'm happy with returning an error here, but the problem is that abis_rsl_rx_rll() propagates that error to libosmo-abis. It shouldn't. Actually, I think we just should return 0 here instead of an error. Whether to forward the message or not to an SCCP connection is an internal question for the GSM 04.07 code, I would say. And thus should stay within gsm0408_rcvmsg(). abis_rsl_rx_rll() shouldn't know about these decisions and should only care about real errors. If that's an acceptable solution, I'll submit a new version of the patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18438 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2d430ebc894a2345bebaa1841a75e94a3b45eae2 Gerrit-Change-Number: 18438 Gerrit-PatchSet: 1 Gerrit-Owner: ipse <Alexander.Chemeris at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: ipse <Alexander.Chemeris at gmail.com> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 25 May 2020 21:23:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200525/5f12e5b6/attachment.htm>