Change in osmo-ttcn3-hacks[master]: library/IPA_Types: cosmetic: s/IPAC_IDTAG_UNIT/IPAC_IDTAG_UNITID/g

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon May 25 16:18:33 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18455 )

Change subject: library/IPA_Types: cosmetic: s/IPAC_IDTAG_UNIT/IPAC_IDTAG_UNITID/g
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18455/1/library/IPA_Emulation.ttcnpp 
File library/IPA_Emulation.ttcnpp:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18455/1/library/IPA_Emulation.ttcnpp@368 
PS1, Line 368: 			case (IPAC_IDTAG_UNITID) {
> IPAC_IDTAG_UNIT_ID looks cleaner to me.
Yep, to me too. But this naming is consistent (see IPAC_IDTAG_SERNR, IPAC_IDTAG_IPADDR).



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18455
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iec9cbbea9d38813f0cd3b98fb6b252111d150220
Gerrit-Change-Number: 18455
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 25 May 2020 16:18:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200525/180344d1/attachment.htm>


More information about the gerrit-log mailing list