Change in osmo-bsc[master]: bsc_subscr_conn_fsm: Fix crash in gscon_forget_lchan()

[ipse]

ipse has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18436 )


Change subject: bsc_subscr_conn_fsm: Fix crash in gscon_forget_lchan()
......................................................................

bsc_subscr_conn_fsm: Fix crash in gscon_forget_lchan()

conn->fi might be NULL and thus can't be safely dereferenced.
E.g. we're checking if it's NULL or not just a few lines above. so we
should here as well.

Here is a backtrace for the crash:
(gdb) bt
    at fsm.c:748
    default_timeout=140730455622800, default_timeout at entry=5, file=file at entry=0x55b948079d39 "lchan_fsm.c", line=1344) at tdef.c:346

(gdb) p conn->fi
$1 = (struct osmo_fsm_inst *) 0x0

Change-Id: I2427266ef4660935cde899462fa6df8d785c420e
---
M src/osmo-bsc/bsc_subscr_conn_fsm.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/36/18436/1

diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c b/src/osmo-bsc/bsc_subscr_conn_fsm.c
index 0b475ff..3da9d66 100644
--- a/src/osmo-bsc/bsc_subscr_conn_fsm.c
+++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c
@@ -715,7 +715,7 @@
 				 osmo_fsm_inst_name(conn->fi), detach_label);
 	}
 
-	if (conn->fi->state != ST_CLEARING
+	if ((conn->fi && conn->fi->state != ST_CLEARING)
 	    && !conn->lchan
 	    && !conn->ho.new_lchan
 	    && !conn->assignment.new_lchan)

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18436
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I2427266ef4660935cde899462fa6df8d785c420e
Gerrit-Change-Number: 18436
Gerrit-PatchSet: 1
Gerrit-Owner: ipse <Alexander.Chemeris at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200523/d6bb2b66/attachment.htm>