This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgVadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18365 ) Change subject: gsmtap: Set signal level and SNR fields ...................................................................... Patch Set 3: Code-Review+2 (3 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/18365/3//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-pcu/+/18365/3//COMMIT_MSG@9 PS3, Line 9: lqlual lqual? https://gerrit.osmocom.org/c/osmo-pcu/+/18365/3/src/bts.h File src/bts.h: https://gerrit.osmocom.org/c/osmo-pcu/+/18365/3/src/bts.h@319 PS3, Line 319: send_gsmtap_meas Since we are in C++ world, you could introduce it as an optional parameter, i.e. with default value NULL. But I know you hate ++, so this is just an option, not a merge blocker ;) https://gerrit.osmocom.org/c/osmo-pcu/+/18365/3/src/bts.cpp File src/bts.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/18365/3/src/bts.cpp@437 PS3, Line 437: pcu_l1_meas Damn, I was about to warn that "this may not be initialized", but then realized that it's actually a class, not just a structure o_O. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18365 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibe9502d42c8bd1b984069e7fd805dde87ecbab0c Gerrit-Change-Number: 18365 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Reviewer: tnt <tnt at 246tNt.com> Gerrit-Comment-Date: Wed, 20 May 2020 12:08:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200520/9101bb04/attachment.htm>