Change in libosmo-sccp[master]: big endian: add missing endian.h in sccp.c

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Wed May 20 10:38:41 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/18373 )

Change subject: big endian: add missing endian.h in sccp.c
......................................................................

big endian: add missing endian.h in sccp.c

sccp.c uses #ifdef OSMO_IS_LITTLE_ENDIAN, but fails to include endian.h, i.e.
it would build little endian also on big endian systems.

Found by libosmocore/contrib/struct_endianness.py.

Change-Id: I5906d94e0e0a74674c3a14cf2ec81c681e696474
---
M src/sccp.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/sccp.c b/src/sccp.c
index cbc63b1..058f20b 100644
--- a/src/sccp.c
+++ b/src/sccp.c
@@ -29,6 +29,7 @@
 #include <osmocom/core/msgb.h>
 #include <osmocom/core/talloc.h>
 #include <osmocom/core/logging.h>
+#include <osmocom/core/endian.h>
 #include <osmocom/gsm/tlv.h>
 
 #include <osmocom/sccp/sccp.h>

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/18373
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I5906d94e0e0a74674c3a14cf2ec81c681e696474
Gerrit-Change-Number: 18373
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200520/96a484e7/attachment.htm>


More information about the gerrit-log mailing list