Change in osmo-bsc[master]: bsc_patch: Don't even parse MM INFO if TZ patching is not enabled.

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18340 )

Change subject: bsc_patch: Don't even parse MM INFO if TZ patching is not enabled.
......................................................................

bsc_patch: Don't even parse MM INFO if TZ patching is not enabled.

Change-Id: Ief159111b8753db83861194c2a035a1f08eb77b0
---
M src/osmo-bsc/osmo_bsc_filter.c
1 file changed, 5 insertions(+), 5 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/osmo_bsc_filter.c b/src/osmo-bsc/osmo_bsc_filter.c
index 3b72aee..b4985f2 100644
--- a/src/osmo-bsc/osmo_bsc_filter.c
+++ b/src/osmo-bsc/osmo_bsc_filter.c
@@ -49,6 +49,11 @@
 	uint8_t tzbsd = 0;
 	uint8_t dst = 0;
 
+	/* Is TZ patching enabled? */
+	struct gsm_tz *tz = &conn->network->tz;
+	if (!tz->override)
+		return 0;
+
 	parse_res = tlv_parse(&tp, &gsm48_mm_att_tlvdef, data, length, 0, 0);
 	if (parse_res <= 0 && parse_res != -3)
 		/* FIXME: -3 means unknown IE error, so this accepts messages
@@ -56,11 +61,6 @@
 		 * IE and the message is broken or parsed incompletely. */
 		return 0;
 
-	/* Is TZ patching enabled? */
-	struct gsm_tz *tz = &conn->network->tz;
-	if (!tz->override)
-		return 0;
-
 	/* Convert tz.hr and tz.mn to units */
 	if (tz->hr < 0) {
 		tzunits = -tz->hr*4;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18340
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ief159111b8753db83861194c2a035a1f08eb77b0
Gerrit-Change-Number: 18340
Gerrit-PatchSet: 2
Gerrit-Owner: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200519/3545a5f1/attachment.htm>