This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18336 ) Change subject: pcu: Expect UL ACK/NACK after all UL data is transmitted ...................................................................... pcu: Expect UL ACK/NACK after all UL data is transmitted This is needed since osmo-pcu.git I9b4ef7b7277efa645bdb5becf2e9f6b32c99a9b1, where a bug was fixed in which osmo-pcu was not sending UL ACK/NACK under some conditions. Change-Id: I1a58b3984a96b432b2cb5300fc8a4261133a4f69 --- M pcu/PCU_Tests.ttcn 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Vadim Yanitskiy: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index 5193369..22e3c1f 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -1022,6 +1022,7 @@ var boolean ok; var uint32_t sched_fn; var uint32_t dl_fn; + var uint32_t unused_fn; var OCT4 tlli := '00000001'O; var AckNackDescription ack_nack_desc := valueof(t_AckNackDescription_init); var CodingScheme cs_mcs; @@ -1087,6 +1088,9 @@ /* DL Ass sets poll+rrbp requesting PACKET CONTROL ACK */ f_tx_rlcmac_ul_block(ts_RLCMAC_CTRL_ACK(tlli), 0, sched_fn); + /* PCU acks the UL data after having received CV=0) */ + f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, unused_fn); + /* After acking the dl assignment, dl tbf goes into FLOW state and PCU will provide DL data when BTS asks for it */ f_rx_rlcmac_dl_block_exp_data(dl_block, dl_fn, data, 0, exp_dl_cs_mcs); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18336 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1a58b3984a96b432b2cb5300fc8a4261133a4f69 Gerrit-Change-Number: 18336 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200519/8beba027/attachment.htm>