Change in osmo-ttcn3-hacks[master]: BTS: move ASP_IPA_EVENT_UP handling to f_init_rsl()

[Vadim Yanitskiy]

Vadim Yanitskiy has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18360 )

Change subject: BTS: move ASP_IPA_EVENT_UP handling to f_init_rsl()
......................................................................

BTS: move ASP_IPA_EVENT_UP handling to f_init_rsl()

Change-Id: I2479ce67426810d2789dda885bdbbe82b5d5282a
---
M bts/BTS_Tests.ttcn
1 file changed, 10 insertions(+), 17 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  neels: Looks good to me, approved



diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index d241496..012df47 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -178,6 +178,8 @@
 }
 
 function f_init_rsl(charstring id) runs on test_CT {
+	timer T := mp_ipa_up_timeout;
+
 	vc_IPA := IPA_Emulation_CT.create(id & "-RSL-IPA");
 	vc_RSL := RSL_Emulation_CT.create(id & "-RSL");
 
@@ -187,6 +189,14 @@
 
 	vc_IPA.start(IPA_Emulation.main_server(mp_rsl_ip, mp_rsl_port));
 	vc_RSL.start(RSL_Emulation.main(false));
+
+	T.start;
+	alt {
+	[] RSL_CCHAN.receive(tr_ASP_IPA_EV(ASP_IPA_EVENT_UP));
+	[] T.timeout {
+		Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout waiting for ASP_IPA_EVENT_UP");
+		}
+	}
 }
 
 type record ConnHdlrPars {
@@ -375,7 +385,6 @@
 /* global init function */
 function f_init() runs on test_CT {
 	var charstring id := testcasename();
-	timer T := mp_ipa_up_timeout;
 	g_AllChannels := {
 		/* TS 1..4: TCH/F */
 		valueof(ts_RslChanNr_Bm(1)), valueof(ts_RslChanNr_Bm(2)),
@@ -415,13 +424,6 @@
 		};
 	}
 	f_init_rsl(id);
-	T.start;
-	alt {
-	[] RSL_CCHAN.receive(tr_ASP_IPA_EV(ASP_IPA_EVENT_UP));
-	[] T.timeout {
-		Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout waiting for ASP_IPA_EVENT_UP");
-		}
-	}
 	f_sleep(0.5);	/* workaround for OS#3000 */
 	f_init_vty(id);
 	f_ipa_ctrl_start(mp_ctrl_ip, mp_ctrl_port);
@@ -4950,17 +4952,8 @@
 /* Make sure that GPRS Indicator is absent when the PCU is not connected */
 private function f_TC_pcu_socket_noconnect(RrMessageType si_type)
 runs on test_CT {
-	timer T := 5.0;
-
 	/* don't call f_init() as this would connect PCU socket */
 	f_init_rsl(testcasename());
-	T.start;
-	alt {
-	[] RSL_CCHAN.receive(tr_ASP_IPA_EV(ASP_IPA_EVENT_UP));
-	[] T.timeout {
-		Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout waiting for ASP_IPA_EVENT_UP");
-		}
-	}
 
 	/* Send both System Information Type 3 and 4 (with GPRS Indicator) */
 	f_rsl_bcch_fill(RSL_SYSTEM_INFO_3, ts_SI3_default);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18360
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I2479ce67426810d2789dda885bdbbe82b5d5282a
Gerrit-Change-Number: 18360
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200519/3afee14f/attachment.htm>