Change in osmo-bts[master]: virtual/scheduler: log unknown GSMTAP chan

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Tue May 19 14:05:01 UTC 2020


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18267 )

Change subject: virtual/scheduler: log unknown GSMTAP chan
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/18267/3/src/osmo-bts-virtual/scheduler_virtbts.c 
File src/osmo-bts-virtual/scheduler_virtbts.c:

https://gerrit.osmocom.org/c/osmo-bts/+/18267/3/src/osmo-bts-virtual/scheduler_virtbts.c@83 
PS3, Line 83: 		       rsl_chantype);
it would be good to indicate the source and trajectory of the message. As a reader of the log I would like to not have to guess the context, something like:

  Tx GSMTAP for RSL channel type 0x23: cannot send, this channel type is unknown in GSMTAP

Why is this not LOGL_ERROR?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18267
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ic22ab71e520ab44429a93724250d349d16250801
Gerrit-Change-Number: 18267
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Assignee: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Tue, 19 May 2020 14:05:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200519/7e55d09c/attachment.htm>


More information about the gerrit-log mailing list