Change in osmo-pcu[master]: Get rid of class GprsCodingScheme

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue May 19 09:19:44 UTC 2020


Hello osmith, Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/osmo-pcu/+/18351

to look at the new patch set (#2).

Change subject: Get rid of class GprsCodingScheme
......................................................................

Get rid of class GprsCodingScheme

We have same kind of object splitted into two layers, in coding_scheme
and gprs_coding_scheme. Let's merge them together and get rid of the
class, which is not really useful because it's only a set of functions
operating on one enum value.

This change also fixes gcc 10.1.0 error about memseting a complex type
in rlc.h init().

Change-Id: Ie9ce2144ba9e8dbba9704d4e0000a2929e3e41df
---
M src/Makefile.am
M src/bts.h
M src/coding_scheme.c
M src/coding_scheme.h
M src/decoding.cpp
M src/decoding.h
M src/encoding.cpp
M src/encoding.h
M src/gprs_bssgp_pcu.cpp
D src/gprs_coding_scheme.cpp
D src/gprs_coding_scheme.h
M src/gprs_ms.cpp
M src/gprs_ms.h
M src/pcu_main.cpp
M src/pcu_vty_functions.cpp
M src/pdch.cpp
M src/pdch.h
M src/rlc.cpp
M src/rlc.h
M src/tbf.cpp
M src/tbf.h
M src/tbf_dl.cpp
M src/tbf_dl.h
M src/tbf_ul.cpp
M tests/edge/EdgeTest.cpp
M tests/tbf/TbfTest.cpp
26 files changed, 530 insertions(+), 669 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/51/18351/2
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18351
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ie9ce2144ba9e8dbba9704d4e0000a2929e3e41df
Gerrit-Change-Number: 18351
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200519/2878c8e8/attachment.htm>


More information about the gerrit-log mailing list