Change in osmo-bsc[master]: Fix crash in bsc_patch_mm_info()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

ipse gerrit-no-reply at lists.osmocom.org
Sun May 17 18:21:56 UTC 2020


ipse has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18338 )


Change subject: Fix crash in bsc_patch_mm_info()
......................................................................

Fix crash in bsc_patch_mm_info()

osmo-bsc has crashed with the following backtrace:

Apparently, there is no lchan allocated at this moment, so
conn_get_bts() crashes. But we only use it to get to "network" which
we can do much easier and safer by doing conn->network.

Change-Id: Id3f7b3efba60c0f050c1be98e5e539f1dab4cd57
---
M src/osmo-bsc/osmo_bsc_filter.c
1 file changed, 1 insertion(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/38/18338/1

diff --git a/src/osmo-bsc/osmo_bsc_filter.c b/src/osmo-bsc/osmo_bsc_filter.c
index 332ba6b..3b72aee 100644
--- a/src/osmo-bsc/osmo_bsc_filter.c
+++ b/src/osmo-bsc/osmo_bsc_filter.c
@@ -45,7 +45,6 @@
 {
 	struct tlv_parsed tp;
 	int parse_res;
-	struct gsm_bts *bts = conn_get_bts(conn);
 	int tzunits;
 	uint8_t tzbsd = 0;
 	uint8_t dst = 0;
@@ -58,7 +57,7 @@
 		return 0;
 
 	/* Is TZ patching enabled? */
-	struct gsm_tz *tz = &bts->network->tz;
+	struct gsm_tz *tz = &conn->network->tz;
 	if (!tz->override)
 		return 0;
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18338
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Id3f7b3efba60c0f050c1be98e5e539f1dab4cd57
Gerrit-Change-Number: 18338
Gerrit-PatchSet: 1
Gerrit-Owner: ipse <Alexander.Chemeris at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200517/d0878196/attachment.htm>


More information about the gerrit-log mailing list