Change in osmo-ttcn3-hacks[master]: Move all GPRS helper function to its own file and component

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Sun May 17 16:55:17 UTC 2020


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18333 )

Change subject: Move all GPRS helper function to its own file and component
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18333/2/pcu/GPRS_Components.ttcn 
File pcu/GPRS_Components.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18333/2/pcu/GPRS_Components.ttcn@55 
PS2, Line 55: boolean final := false)
This line needs to be aligned since 'private' keyword was removed.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18333/2/pcu/GPRS_Components.ttcn@66 
PS2, Line 66: BTS.send(ts_RAW_PCU_CMD(GENERAL_CMD_SHUTDOWN));
Wait, where is this line?

  vc_BTS.done; /* wait untill it's done */

It's important to have it here before doing mtc.stop.

Ok, now I see that this function was not removed from PCU_Tests.ttcn, so we have two copies. You can avoid code duplication by marking it as 'friend' to PCU_Tests.ttcn.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18333
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ieae27d6e707f79ec2145864ef5cd67ddbbec9314
Gerrit-Change-Number: 18333
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sun, 17 May 2020 16:55:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200517/12c141ab/attachment.htm>


More information about the gerrit-log mailing list