Change in osmocom-bb[master]: trxcon: refactor trx_if_cmd_setfh(): send Rx/Tx frequencies

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Sun May 17 07:47:42 UTC 2020


Hello laforge, Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/osmocom-bb/+/18319

to look at the new patch set (#4).

Change subject: trxcon: refactor trx_if_cmd_setfh(): send Rx/Tx frequencies
......................................................................

trxcon: refactor trx_if_cmd_setfh(): send Rx/Tx frequencies

It would make sense to send the ARFCN list in parameters of SETFH
command, if there was a clear distinction between transceivers in
fake_trx.py, i.e. which one is an MS and which is a BTS.

Right now, every Transceiver is an abstract entity that emits
and receives bursts. So when you convert an ARFCN to a pair of
Downlink/Uplink frequencies, you don't know whether it maps
as Rx/Tx or as Tx/Rx for a given Transceiver.

Of course, we could assume that this is an MS specific feature,
and a pair of Downlink/Uplink frequencies always corresponds to
Rx/Tx, but what if some day we would need to implement and test
a similar approach for the BTS side? Also, by sending frequency
values in kHz (rather than ARFCNs) we can avoid inconsistency
with the existing RXTUNE / TXTUNE commands.

Change-Id: Ia2bf08797f1a37b56cf47945694b901f92765b58
Related: I587e4f5da67c7b7f28e010ed46b24622c31a3fdd
Related: OS#4546
---
M src/host/trxcon/trx_if.c
1 file changed, 36 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/19/18319/4
-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/18319
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ia2bf08797f1a37b56cf47945694b901f92765b58
Gerrit-Change-Number: 18319
Gerrit-PatchSet: 4
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200517/08ef7e81/attachment.htm>


More information about the gerrit-log mailing list