Change in osmo-ttcn3-hacks[master]: pcu: Use BS_CV_MAX in f_tx_rlcmac_ul_n_blocks

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun May 17 07:26:36 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18258 )

Change subject: pcu: Use BS_CV_MAX in f_tx_rlcmac_ul_n_blocks
......................................................................

pcu: Use BS_CV_MAX in f_tx_rlcmac_ul_n_blocks

Also increment BSN with each new submitted packet.

Change-Id: I685d1535154197bb85e18875e0a4d41122a24fa0
---
M pcu/PCU_Tests.ttcn
1 file changed, 11 insertions(+), 3 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn
index 044d368..a550650 100644
--- a/pcu/PCU_Tests.ttcn
+++ b/pcu/PCU_Tests.ttcn
@@ -136,6 +136,9 @@
 	var uint8_t g_mcs_max_dl := 9;
 	var uint8_t g_mcs_max_ul := 9;
 
+	/* Value at which Countdown Procedure starts. Announced by network (GPRS Cell Options as per TS 04.60 Chapter 12.24) */
+	var uint4_t g_bs_cv_max := 4;
+
 	var boolean g_egprs_only := false;
 	var boolean g_force_two_phase_access := false;
 
@@ -533,8 +536,8 @@
 runs on RAW_PCU_Test_CT {
 	var template (value) RlcmacUlBlock ul_data := t_RLCMAC_UL_DATA(
 		tfi := tfi,
-		cv := num_blocks - 1, /* num UL blocks to be sent (to be overridden in loop) */
-		bsn := 0, /* TODO: what should be here? */
+		cv := 15, /* num UL blocks to be sent (to be overridden in loop) */
+		bsn := 0, /* TODO: what should be initial value? */
 		blocks := { /* To be generated in loop */ });
 
 	if (not istemplatekind(tlli, "omit")) {
@@ -544,7 +547,12 @@
 
 	for (var integer i := 0; i < num_blocks; i := i + 1) {
 		/* Prepare a new UL block (CV, random payload) */
-		ul_data.data.mac_hdr.countdown := (num_blocks - i - 1);
+		var integer cv := num_blocks - i - 1;
+		if (cv > g_bs_cv_max) {
+			cv := 15;
+		}
+		ul_data.data.mac_hdr.countdown := cv;
+		ul_data.data.mac_hdr.bsn := i;
 		ul_data.data.blocks := { valueof(t_RLCMAC_LLCBLOCK(f_rnd_octstring(10))) };
 		f_tx_rlcmac_ul_block(ul_data);
 	}

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18258
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I685d1535154197bb85e18875e0a4d41122a24fa0
Gerrit-Change-Number: 18258
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200517/c952e3f0/attachment.htm>


More information about the gerrit-log mailing list