This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18326 ) Change subject: oml: fix oml_mo_tx_sw_act_rep(): do not allocate FOM header twice ...................................................................... oml: fix oml_mo_tx_sw_act_rep(): do not allocate FOM header twice This redundant call to msgb_put() appends five '00'O octets to the "Software Activated Report" message, so they look like an unknown attribute(s). I accidentally noticed this in Wireshark. Change-Id: I7377575135f4a154572891d1b5b39ff814b97f38 --- M src/common/oml.c 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/common/oml.c b/src/common/oml.c index 7a62faa..7e3b834 100644 --- a/src/common/oml.c +++ b/src/common/oml.c @@ -472,7 +472,6 @@ if (!nmsg) return -ENOMEM; - msgb_put(nmsg, sizeof(struct abis_om_fom_hdr)); return oml_mo_send_msg(mo, nmsg, NM_MT_SW_ACTIVATED_REP); } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18326 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I7377575135f4a154572891d1b5b39ff814b97f38 Gerrit-Change-Number: 18326 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200516/75a4b881/attachment.htm>