Change in osmo-ttcn3-hacks[master]: pcu: Introduce TC_mo_ping_pong_with_ul_racap_egprs_only

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Sat May 16 18:12:08 UTC 2020


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18253 )

Change subject: pcu: Introduce TC_mo_ping_pong_with_ul_racap_egprs_only
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18253/2/pcu/PCU_Tests.ttcn 
File pcu/PCU_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18253/2/pcu/PCU_Tests.ttcn@265 
PS2, Line 265: f_rlcmac_dl_block_get_cs_mcs
There should be a clear distinction, whether this function is supposed to determine the actual coding scheme of a given block (no matter, data or control), or is it supposed to parse the value indicated in the 'Channel Coding Command' field. This functionality should not be mixed together. There is no limitation on total amount of functions, so let's make them do something specific and add more if needed.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18253
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I396dbd0ca200fbf9365c534f4d479f903d0417ff
Gerrit-Change-Number: 18253
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sat, 16 May 2020 18:12:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200516/cb92f161/attachment.htm>


More information about the gerrit-log mailing list