Change in osmo-bsc[master]: bssmap: Ignore repeated BSSMAP RESET ACK messages.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

ipse gerrit-no-reply at lists.osmocom.org
Sat May 16 15:08:21 UTC 2020


ipse has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18330 )


Change subject: bssmap: Ignore repeated BSSMAP RESET ACK messages.
......................................................................

bssmap: Ignore repeated BSSMAP RESET ACK messages.

We're sending multiple RESET messages to establish a conection with
an MSC and MSC can (and often will) respond with multiple RESET ACK
messages. We should not treat this as an ERROR as it used to be
in the original code.

Change-Id: I109d638d5167e24f0357e3541415b9e7269aa5d1
---
M src/osmo-bsc/a_reset.c
1 file changed, 4 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/30/18330/1

diff --git a/src/osmo-bsc/a_reset.c b/src/osmo-bsc/a_reset.c
index f990e63..713be86 100644
--- a/src/osmo-bsc/a_reset.c
+++ b/src/osmo-bsc/a_reset.c
@@ -103,6 +103,9 @@
 	case EV_N_CONNECT:
 		reset_ctx->conn_loss_counter = 0;
 		break;
+	case EV_RESET_ACK:
+		LOGPFSML(fi, LOGL_INFO, "Received a duplicated BSSMAP RESET ACK, ignoring\n");
+		break;
 	}
 }
 
@@ -140,7 +143,7 @@
 		     .onenter = fsm_disc_onenter_cb,
 		     },
 	[ST_CONN] = {
-		     .in_event_mask = (1 << EV_N_DISCONNECT) | (1 << EV_N_CONNECT),
+		     .in_event_mask = (1 << EV_N_DISCONNECT) | (1 << EV_N_CONNECT) | (1 << EV_RESET_ACK),
 		     .out_state_mask = (1 << ST_DISC) | (1 << ST_CONN),
 		     .name = "CONN",
 		     .action = fsm_conn_cb,

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18330
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I109d638d5167e24f0357e3541415b9e7269aa5d1
Gerrit-Change-Number: 18330
Gerrit-PatchSet: 1
Gerrit-Owner: ipse <Alexander.Chemeris at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200516/8ff5fedc/attachment.htm>


More information about the gerrit-log mailing list