Change in osmo-pcu[master]: tbf_ul: Fix UL ACK not sent to MS if intermediate UL block is lost

[pespin]

Hello Vadim Yanitskiy, Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/osmo-pcu/+/18323

to look at the new patch set (#2).

Change subject: tbf_ul: Fix UL ACK not sent to MS if intermediate UL block is lost
......................................................................

tbf_ul: Fix UL ACK not sent to MS if intermediate UL block is lost

In normal conditions ACKing of UL blocks is only sent every
SEND_ACK_AFTER_FRAMES (20) frames. Which means if CV=0 is received (and
hence no more packets are received) less than 20 frames before a lost,
the PCU won't ask for a retransmission and wait there until some timer
destroys the TBF.

This issue is shown by TTCN3 test PCU_Tests.ttcn
TC_ul_intermediate_retrans.

Unit tests triggering this condition are adapted. Some similar tests are
not triggering it because BSN/CV relation being used is totally wrong
(like CV=0 being sent on a BSN with previous value than others).

Change-Id: I9b4ef7b7277efa645bdb5becf2e9f6b32c99a9b1
---
M src/tbf_ul.cpp
M src/tbf_ul.h
M tests/tbf/TbfTest.cpp
M tests/tbf/TbfTest.err
4 files changed, 25 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/23/18323/2
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18323
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I9b4ef7b7277efa645bdb5becf2e9f6b32c99a9b1
Gerrit-Change-Number: 18323
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200515/3e53a1b5/attachment.htm>