Change in libosmocore[master]: gsm0808: Implement helper functions for CONFUSION BSSMAP message deco...

[ipse]

ipse has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18231 )

Change subject: gsm0808: Implement helper functions for CONFUSION BSSMAP message decoding.
......................................................................


Patch Set 1:

(5 comments)

https://gerrit.osmocom.org/c/libosmocore/+/18231/1/include/osmocom/gsm/gsm0808.h 
File include/osmocom/gsm/gsm0808.h:

https://gerrit.osmocom.org/c/libosmocore/+/18231/1/include/osmocom/gsm/gsm0808.h@322 
PS1, Line 322: diagnostics
> Could be shortened to '_diag_oct_loc_str'. Not critical.
Why speak in riddles and make reading the code hard?


https://gerrit.osmocom.org/c/libosmocore/+/18231/1/include/osmocom/gsm/protocol/gsm_08_08.h 
File include/osmocom/gsm/protocol/gsm_08_08.h:

https://gerrit.osmocom.org/c/libosmocore/+/18231/1/include/osmocom/gsm/protocol/gsm_08_08.h@674 
PS1, Line 674: struct gsm0808_diagnostics {
> Hint: Probably better to generate bigendian/littleendian with ./contrib/struct_endianess. […]
Done


https://gerrit.osmocom.org/c/libosmocore/+/18231/1/src/gsm/gsm0808.c 
File src/gsm/gsm0808.c:

https://gerrit.osmocom.org/c/libosmocore/+/18231/1/src/gsm/gsm0808.c@40 
PS1, Line 40: static __thread char str_buff[512];
> As Usual, I don't really like adding more and more static buffers every time we add some function. […]
Is this really critical? Using a caller allocated but makes the user code quite ugly


https://gerrit.osmocom.org/c/libosmocore/+/18231/1/src/gsm/gsm0808.c@1682 
PS1, Line 1682: else if (pointer == 1)
> If possible, would be nice to use a 'value_string' here, or at least the 'switch' statement.
Makes sense


https://gerrit.osmocom.org/c/libosmocore/+/18231/1/tests/gsm0808/gsm0808_test.c 
File tests/gsm0808/gsm0808_test.c:

https://gerrit.osmocom.org/c/libosmocore/+/18231/1/tests/gsm0808/gsm0808_test.c@393 
PS1, Line 393: 	
> whitespace
Ack



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18231
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If8afd2d096fb66c6c2f255a08fc1129de3d09cec
Gerrit-Change-Number: 18231
Gerrit-PatchSet: 1
Gerrit-Owner: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 14 May 2020 17:53:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200514/ccb0d5bf/attachment.htm>