Change in libosmocore[master]: codec: Add functions for AMR s->d bits and d->s bits

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

tnt gerrit-no-reply at lists.osmocom.org
Thu May 14 10:46:54 UTC 2020


tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18246 )

Change subject: codec: Add functions for AMR s->d bits and d->s bits
......................................................................


Patch Set 2:

(3 comments)

https://gerrit.osmocom.org/c/libosmocore/+/18246/2/src/codec/gsm690.c 
File src/codec/gsm690.c:

https://gerrit.osmocom.org/c/libosmocore/+/18246/2/src/codec/gsm690.c@4 
PS2, Line 4:  * (C) 2010 Sylvain Munaut <tnt at 246tNt.com>
wtf ... 10 years ago ... damn.


https://gerrit.osmocom.org/c/libosmocore/+/18246/2/src/codec/gsm690.c@278 
PS2, Line 278: 	if (n_bits >= tbl->len)
Should be > and not >=


https://gerrit.osmocom.org/c/libosmocore/+/18246/2/src/codec/gsm690.c@304 
PS2, Line 304: 	if (n_bits >= tbl->len)
Same as above



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18246
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia4ac2aea2e96f9185f082a07ca64dfc5276efb46
Gerrit-Change-Number: 18246
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: tnt <tnt at 246tNt.com>
Gerrit-Comment-Date: Thu, 14 May 2020 10:46:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200514/a742dc48/attachment.htm>


More information about the gerrit-log mailing list