Change in osmo-ttcn3-hacks[master]: pcu: use correct RA type to properly test 2phase access

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Wed May 13 16:45:03 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18239 )

Change subject: pcu: use correct RA type to properly test 2phase access
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18239/1/pcu/PCU_Tests.ttcn 
File pcu/PCU_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18239/1/pcu/PCU_Tests.ttcn@253 
PS1, Line 253: ischosen
Please use template(s) here, otherwise it's hard to read this code.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18239/1/pcu/PCU_Tests.ttcn@608 
PS1, Line 608: Uplink
Downlink


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18239/1/pcu/PCU_Tests.ttcn@612 
PS1, Line 612: f_rrbp_ack_fn
So here we assume that RRBP is always valid for DL Assignment? If so, let's add a comment.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18239
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If636a4898dfa175fdbd6baf04f7f2c955a9c525d
Gerrit-Change-Number: 18239
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 13 May 2020 16:45:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200513/98c91171/attachment.htm>


More information about the gerrit-log mailing list