This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18235 ) Change subject: pcu: f_dl_block_ack_fn(): Allow passing ctrl dl_block ...................................................................... pcu: f_dl_block_ack_fn(): Allow passing ctrl dl_block Downlink Control blocks like Packet Uplink Assignment (PACCH) contain rrbp + rrbp_valid in mac headers Change-Id: I0401b0b378c7770d06a15d14dac6436303b4ccab --- M pcu/PCU_Tests.ttcn 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index efb7d94..5ef53a9 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -708,9 +708,8 @@ rrbp_valid := dl_block.data.mac_hdr.mac_hdr.rrbp_valid; rrbp := dl_block.data.mac_hdr.mac_hdr.rrbp; } else { - /* Should not happen, but the caller may theoretically give us a CTRL block */ - setverdict(fail, "DL block is neither GPRS nor EGPRS data block: ", dl_block); - f_shutdown(__BFILE__, __LINE__); + rrbp_valid := dl_block.ctrl.mac_hdr.rrbp_valid; + rrbp := dl_block.ctrl.mac_hdr.rrbp; } /* Make sure that the given block really needs to be ACKnowledged */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18235 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0401b0b378c7770d06a15d14dac6436303b4ccab Gerrit-Change-Number: 18235 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200513/2d68a8df/attachment.htm>