Change in osmo-bsc[master]: stats: Add counters and gauges for BORKEN lchans/TS

[neels]

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18192 )

Change subject: stats: Add counters and gauges for BORKEN lchans/TS
......................................................................


Patch Set 4: Code-Review-1

(3 comments)

This change is ready for review.

https://gerrit.osmocom.org/c/osmo-bsc/+/18192/4/src/osmo-bsc/bsc_vty.c 
File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/18192/4/src/osmo-bsc/bsc_vty.c@5010 
PS4, Line 5010: 		if (lchan->fi->state == LCHAN_ST_UNUSED) {
(unrelated cosmetic change)


https://gerrit.osmocom.org/c/osmo-bsc/+/18192/4/src/osmo-bsc/lchan_fsm.c 
File src/osmo-bsc/lchan_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/18192/4/src/osmo-bsc/lchan_fsm.c@1413 
PS4, Line 1413: {
you need to also change the stat item and possibly also add a counter here,
to track those lchans leaving the BORKEN state because the BTS restarted.
The lchan will be deallocated, which calls this cleanup function. The fi->state should still be valid.


https://gerrit.osmocom.org/c/osmo-bsc/+/18192/4/src/osmo-bsc/timeslot_fsm.c 
File src/osmo-bsc/timeslot_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/18192/4/src/osmo-bsc/timeslot_fsm.c@899 
PS4, Line 899: 	.allstate_action = ts_fsm_allstate,
you also need to add a cleanup function to track those TS leaving the BORKEN state due to FSM deallocation (BTS restart)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18192
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I427bbe1613a0e92bff432a7d76592fe50f620ebe
Gerrit-Change-Number: 18192
Gerrit-PatchSet: 4
Gerrit-Owner: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Assignee: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 13 May 2020 13:06:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200513/e52f7e96/attachment.htm>