Change in libosmocore[master]: gsm0808: Implement helper functions for CONFUSION BSSMAP message deco...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed May 13 11:40:35 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18231 )

Change subject: gsm0808: Implement helper functions for CONFUSION BSSMAP message decoding.
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/c/libosmocore/+/18231/1/include/osmocom/gsm/protocol/gsm_08_08.h 
File include/osmocom/gsm/protocol/gsm_08_08.h:

https://gerrit.osmocom.org/c/libosmocore/+/18231/1/include/osmocom/gsm/protocol/gsm_08_08.h@674 
PS1, Line 674: struct gsm0808_diagnostics {
Hint: Probably better to generate bigendian/littleendian with ./contrib/struct_endianess.py, to make sure when run afterwards it won't generate a different output.


https://gerrit.osmocom.org/c/libosmocore/+/18231/1/src/gsm/gsm0808.c 
File src/gsm/gsm0808.c:

https://gerrit.osmocom.org/c/libosmocore/+/18231/1/src/gsm/gsm0808.c@40 
PS1, Line 40: static __thread char str_buff[512];
As Usual, I don't really like adding more and more static buffers every time we add some function. Let's change the APIs to use caller allocated buf.


https://gerrit.osmocom.org/c/libosmocore/+/18231/1/tests/gsm0808/gsm0808_test.c 
File tests/gsm0808/gsm0808_test.c:

https://gerrit.osmocom.org/c/libosmocore/+/18231/1/tests/gsm0808/gsm0808_test.c@393 
PS1, Line 393: 	
whitespace



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18231
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If8afd2d096fb66c6c2f255a08fc1129de3d09cec
Gerrit-Change-Number: 18231
Gerrit-PatchSet: 1
Gerrit-Owner: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 13 May 2020 11:40:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200513/2066918b/attachment.htm>


More information about the gerrit-log mailing list