Change in osmo-msc[master]: gsup_client_mux_tx_error_reply(): handle optional routing IEs

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Mon May 11 12:32:53 UTC 2020


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/17984 )

Change subject: gsup_client_mux_tx_error_reply(): handle optional routing IEs
......................................................................


Patch Set 1: Code-Review-1

best use the new osmo_gsup_make_response() which is written for this purpose:
form a response to a received GSUP message, making sure that all routing and session info is returned correctly. The aim is to avoid code dup of implementations to form a correct response with hidden bugs here and there. Instead, if all code uses osmo_gsup_make_response(), we are conforming everywhere (and fix possible bugs in one place).

Was recently merged to libosmo-gsup-client

Ideally we'd refactor to use osmo_gsup_req in osmo-msc, but that is beyond this patch.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/17984
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I2694ea15d2cf57316f2eae845afb957a3e8067b6
Gerrit-Change-Number: 17984
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 11 May 2020 12:32:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200511/4a540e66/attachment.htm>


More information about the gerrit-log mailing list