Change in osmo-bsc[master]: stats: Only dereference a connection pointer after checking for NULL.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

ipse gerrit-no-reply at lists.osmocom.org
Sun May 10 21:34:39 UTC 2020


ipse has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18188 )


Change subject: stats: Only dereference a connection pointer after checking for NULL.
......................................................................

stats: Only dereference a connection pointer after checking for NULL.

Addresses CID 210261.

Change-Id: Ic7e7c92c5b9ff696fa7f4cd0d69451cd22333f71
---
M src/osmo-bsc/osmo_bsc_bssap.c
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/88/18188/1

diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c
index f1e43be..b92e39a 100644
--- a/src/osmo-bsc/osmo_bsc_bssap.c
+++ b/src/osmo-bsc/osmo_bsc_bssap.c
@@ -1104,7 +1104,7 @@
 	struct msgb *gsm48;
 	uint8_t *data;
 	int rc, dtap_rc;
-	struct rate_ctr *ctrs = conn->sccp.msc->msc_ctrs->ctr;
+	struct rate_ctr *ctrs;
 
 	LOGP(DMSC, LOGL_DEBUG, "Rx MSC DTAP: %s\n",
 		osmo_hexdump(msg->l3h, length));
@@ -1114,6 +1114,7 @@
 		return -1;
 	}
 
+	ctrs = conn->sccp.msc->msc_ctrs->ctr;
 	header = (struct dtap_header *) msg->l3h;
 	if (sizeof(*header) >= length) {
 		rate_ctr_inc(&ctrs[MSC_CTR_BSSMAP_RX_DTAP_ERROR]);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18188
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ic7e7c92c5b9ff696fa7f4cd0d69451cd22333f71
Gerrit-Change-Number: 18188
Gerrit-PatchSet: 1
Gerrit-Owner: ipse <Alexander.Chemeris at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200510/c1cb2e6f/attachment.htm>


More information about the gerrit-log mailing list