Change in osmo-bsc[master]: timeslot_fsm: Allow PDCH_ACT_ACK in BORKEN state.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

ipse gerrit-no-reply at lists.osmocom.org
Sat May 9 19:52:06 UTC 2020


ipse has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18171 )


Change subject: timeslot_fsm: Allow PDCH_ACT_ACK in BORKEN state.
......................................................................

timeslot_fsm: Allow PDCH_ACT_ACK in BORKEN state.

It should be fine if we receive PDCH_ACT_ACK late. We should just go
into the PDCH state as normal.

Change-Id: If816b681e0b2e76fb7122cf211e15eeee92451ee
---
M src/osmo-bsc/timeslot_fsm.c
1 file changed, 8 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/71/18171/1

diff --git a/src/osmo-bsc/timeslot_fsm.c b/src/osmo-bsc/timeslot_fsm.c
index 91b6b54..f8adfb6 100644
--- a/src/osmo-bsc/timeslot_fsm.c
+++ b/src/osmo-bsc/timeslot_fsm.c
@@ -668,6 +668,12 @@
 			return;
 		}
 
+	case TS_EV_PDCH_ACT_ACK:
+		/* Late PDCH activation ACK is not a crime.
+		 * Just go into the PDCH mode as normal. */
+		osmo_fsm_inst_state_chg(fi, TS_ST_PDCH, 0, 0);
+		return;
+
 	default:
 		OSMO_ASSERT(false);
 	}
@@ -820,9 +826,11 @@
 		.in_event_mask = 0
 			| S(TS_EV_LCHAN_REQUESTED)
 			| S(TS_EV_LCHAN_UNUSED)
+			| S(TS_EV_PDCH_ACT_ACK)
 			,
 		.out_state_mask = 0
 			| S(TS_ST_NOT_INITIALIZED)
+			| S(TS_ST_PDCH)
 			,
 	},
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18171
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If816b681e0b2e76fb7122cf211e15eeee92451ee
Gerrit-Change-Number: 18171
Gerrit-PatchSet: 1
Gerrit-Owner: ipse <Alexander.Chemeris at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200509/62a1876b/attachment.htm>


More information about the gerrit-log mailing list