Change in osmo-bsc[master]: a_reset: Rename SIGTRAN connection to BSSMAP MSC assocation in log me...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

ipse gerrit-no-reply at lists.osmocom.org
Sat May 9 18:02:14 UTC 2020


ipse has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18158 )

Change subject: a_reset: Rename SIGTRAN connection to BSSMAP MSC assocation in log messages
......................................................................

a_reset: Rename SIGTRAN connection to BSSMAP MSC assocation in log messages

Explanation from Harald:
There are plenty of things that can happen above the bare SCTP/M3UA
connection which can happen, such as SCCP or MTP level routing
problems.

The fact that a MSC responds to a BSSMAP reset tells us that all of
the underlying SS7 transport network is operational and the MSC
responds to us.

Go draw an IP analogy: Saying "SIGTAN connection up" here is like
saying "Ethernet link up" when you get an ICMP response.

Change-Id: If9d37c94f2f2b6cffef97f445774766993f538db
---
M src/osmo-bsc/a_reset.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  laforge: Looks good to me, but someone else must approve
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/a_reset.c b/src/osmo-bsc/a_reset.c
index 63273e9..f990e63 100644
--- a/src/osmo-bsc/a_reset.c
+++ b/src/osmo-bsc/a_reset.c
@@ -82,7 +82,7 @@
 	struct reset_ctx *reset_ctx = (struct reset_ctx *)fi->priv;
 	struct bsc_msc_data *msc = reset_ctx->priv;
 
-	LOGPFSML(fi, LOGL_NOTICE, "SIGTRAN connection down, reconnecting...\n");
+	LOGPFSML(fi, LOGL_NOTICE, "BSSMAP MSC assocation is down, reconnecting...\n");
 	if (prev_state != ST_DISC)
 		osmo_stat_item_dec(msc->msc_statg->items[MSC_STAT_MSC_LINKS_ACTIVE], 1);
 }
@@ -112,7 +112,7 @@
 	struct reset_ctx *reset_ctx = (struct reset_ctx *)fi->priv;
 	struct bsc_msc_data *msc = reset_ctx->priv;
 
-	LOGPFSML(fi, LOGL_NOTICE, "SIGTRAN connection succeeded.\n");
+	LOGPFSML(fi, LOGL_NOTICE, "BSSMAP MSC assocation is up.\n");
 	if (prev_state != ST_CONN)
 		osmo_stat_item_inc(msc->msc_statg->items[MSC_STAT_MSC_LINKS_ACTIVE], 1);
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18158
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If9d37c94f2f2b6cffef97f445774766993f538db
Gerrit-Change-Number: 18158
Gerrit-PatchSet: 2
Gerrit-Owner: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200509/4f20abcb/attachment.htm>


More information about the gerrit-log mailing list