Change in libosmocore[master]: stats: Change timer to timerfd to make it a true interval timer.

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18141 )

Change subject: stats: Change timer to timerfd to make it a true interval timer.
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.osmocom.org/c/libosmocore/+/18141/3/src/stats.c 
File src/stats.c:

https://gerrit.osmocom.org/c/libosmocore/+/18141/3/src/stats.c@158 
PS3, Line 158: 	
trailing whitespace


https://gerrit.osmocom.org/c/libosmocore/+/18141/3/src/stats.c@160 
PS3, Line 160: 		LOGP(DLSTATS, LOGL_NOTICE, "Stats timer expire_count=%"PRIu64": We missed %"PRIu64" timers\n",
In general it's better to leave a space between a string literal and PRIu64 (which is another string literal). Some compilers don't like that, I have seen it. In essence: printf("hello""howareyou") -> printf("hello" "howareyou")



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18141
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I23d8b5157ef8a9833ba16a81d9b28a126f303c30
Gerrit-Change-Number: 18141
Gerrit-PatchSet: 3
Gerrit-Owner: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Sat, 09 May 2020 13:01:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200509/d764114f/attachment.htm>