Change in osmo-pcu[master]: fix egprs_mslot_class_from_ra(): multislot class may not be present

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sat May 9 10:20:46 UTC 2020


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18157 )


Change subject: fix egprs_mslot_class_from_ra(): multislot class may not be present
......................................................................

fix egprs_mslot_class_from_ra(): multislot class may not be present

For more details, see 3GPP TS 44.060, table 11.2.5a.2.

Change-Id: Iba0466b29afd26cff317ed4fb6749f8a3079f16a
Signed-off-by: Vadim Yanitskiy <axilirator at gmail.com>
---
M src/bts.cpp
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/57/18157/1

diff --git a/src/bts.cpp b/src/bts.cpp
index 6578e06..2c9ec69 100644
--- a/src/bts.cpp
+++ b/src/bts.cpp
@@ -675,7 +675,8 @@
  */
 static inline uint8_t egprs_mslot_class_from_ra(uint16_t ra, bool is_11bit)
 {
-	if (is_11bit)
+	/* EGPRS multislot class is only present in One Phase Access Request */
+	if (is_11bit && (ra >> 10) == 0x00) /* 0xxx xxxx xxx */
 		return ((ra & 0x3e0) >> 5) + 1;
 
 	/* set EGPRS multislot class to 0 for 8-bit RACH, since we don't know it yet */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18157
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Iba0466b29afd26cff317ed4fb6749f8a3079f16a
Gerrit-Change-Number: 18157
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200509/cf7081aa/attachment.htm>


More information about the gerrit-log mailing list