Change in libosmocore[master]: stats: Change timer to timerfd to make it a true interval timer.

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18141 )

Change subject: stats: Change timer to timerfd to make it a true interval timer.
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

https://gerrit.osmocom.org/c/libosmocore/+/18141/1/src/stats.c 
File src/stats.c:

https://gerrit.osmocom.org/c/libosmocore/+/18141/1/src/stats.c@105 
PS1, Line 105: static struct osmo_fd osmo_stats_timer = {.fd=-1};
= { .fd = -1 };


https://gerrit.osmocom.org/c/libosmocore/+/18141/1/src/stats.c@149 
PS1, Line 149: 	if (!(what & BSC_FD_READ))
BSC_FD_ is only available for backward compat. Use OSMO_FD_READ instead.


https://gerrit.osmocom.org/c/libosmocore/+/18141/1/src/stats.c@156 
PS1, Line 156: 	OSMO_ASSERT(rc == sizeof(expire_count));
osmo_panic() printing rc value would be more valuable if this ever happens.


https://gerrit.osmocom.org/c/libosmocore/+/18141/1/src/stats.c@157 
PS1, Line 157: 
I would also add a print NOTICE if expire_count > 1 (or a counter too if you want).



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18141
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I23d8b5157ef8a9833ba16a81d9b28a126f303c30
Gerrit-Change-Number: 18141
Gerrit-PatchSet: 1
Gerrit-Owner: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sat, 09 May 2020 00:18:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200509/9e4eda5e/attachment.htm>