Change in osmo-bsc[master]: stats: Add a stats gauge for the MSC links count.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Fri May 8 21:25:05 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18092 )

Change subject: stats: Add a stats gauge for the MSC links count.
......................................................................


Patch Set 7: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/18092/7/include/osmocom/bsc/bsc_msc_data.h 
File include/osmocom/bsc/bsc_msc_data.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/18092/7/include/osmocom/bsc/bsc_msc_data.h@61 
PS7, Line 61: 	MSC_STAT_MSC_LINKS_ACTIVE,
why repeating MSC twice in naming?


https://gerrit.osmocom.org/c/osmo-bsc/+/18092/7/src/osmo-bsc/a_reset.c 
File src/osmo-bsc/a_reset.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/18092/7/src/osmo-bsc/a_reset.c@188 
PS7, Line 188: 	osmo_stat_item_inc(msc->msc_statg->items[MSC_STAT_MSC_LINKS_TOTAL], 1);
afaiu this is never decreased, is that fine?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18092
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ibe4b29056ba704a27b925cfdba49f343ee34f428
Gerrit-Change-Number: 18092
Gerrit-PatchSet: 7
Gerrit-Owner: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 08 May 2020 21:25:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200508/d8cd996c/attachment.htm>


More information about the gerrit-log mailing list