Change in osmo-bsc[master]: om2k: Wait for OM TRX links to stabilize before trying to bring up TRX

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

tnt gerrit-no-reply at lists.osmocom.org
Fri May 8 13:40:29 UTC 2020


tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18126 )

Change subject: om2k: Wait for OM TRX links to stabilize before trying to bring up TRX
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/18126/2/src/osmo-bsc/abis_om2000.c 
File src/osmo-bsc/abis_om2000.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/18126/2/src/osmo-bsc/abis_om2000.c@2408 
PS2, Line 2408: 	OSMO_ASSERT(event == OM2K_BTS_EVT_MCTR_DONE);
> That's not needed, the FSM already protects you from its fsm definition.
That's for consistency for every other FSM in that file ...



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18126
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I55a06e08b9c52ff6e97e8c72f2d55770809eba51
Gerrit-Change-Number: 18126
Gerrit-PatchSet: 5
Gerrit-Owner: tnt <tnt at 246tNt.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 08 May 2020 13:40:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200508/b31161a1/attachment.htm>


More information about the gerrit-log mailing list