Change in libosmo-abis[master]: e1_input: Add VTY command to enable PCAP debug output

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

tnt gerrit-no-reply at lists.osmocom.org
Fri May 8 13:37:22 UTC 2020


tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/18114 )

Change subject: e1_input: Add VTY command to enable PCAP debug output
......................................................................


Patch Set 3:

(1 comment)

> Patch Set 3: Code-Review+1
> 
> (1 comment)

https://gerrit.osmocom.org/c/libosmo-abis/+/18114/1/src/e1_input_vty.c 
File src/e1_input_vty.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/18114/1/src/e1_input_vty.c@267 
PS1, Line 267: 	e1_set_pcap_fd(-1);
> will it be closed when all the lines using it become inactive? (can that ever happen?) […]
No it won't be closed.

But in anycase that's not the job of the VTY to deal with that. e1_set_pcap_fd itself should deal with that but IMHO it's not worth the trouble. This is a barlely used debug feature that's been disabled for years and nobody cared ... 

I'm not even sure the 'no' command makes any sense and if there was an easy way to make the 'set' command to _only_ be usable at boot and at no other point, I'd do that.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/18114
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I0b4251702aecd6721b9d63c320351ef6cb513454
Gerrit-Change-Number: 18114
Gerrit-PatchSet: 3
Gerrit-Owner: tnt <tnt at 246tNt.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-Comment-Date: Fri, 08 May 2020 13:37:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: tnt <tnt at 246tNt.com>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200508/800dc6a1/attachment.htm>


More information about the gerrit-log mailing list