Change in osmo-pcu[master]: bts: Fix Decoding EGPRS MultislotClass from 11-bit EGPRS PACKET CHANN...

[pespin]

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18130 )


Change subject: bts: Fix Decoding EGPRS MultislotClass from 11-bit EGPRS PACKET CHANNEL REQUEST
......................................................................

bts: Fix Decoding EGPRS MultislotClass from 11-bit EGPRS PACKET CHANNEL REQUEST

In osmo-pcu datatructures, the variables holding multislot classes
simply contain an integer referring to the multislot class number,
instead of coding from 3GPP TS 44.060 Table 11.2.5.3 and Table
11.2.5a.3.

So coding Multislot class 3 is stored as 0x03 in osmo-pcu variables,
while in 3GPP TS 44.060 coding it's coded as 0x02 (N-1).
This allows us using value 0x00 to designate a "yet unknown (EGPRS) Multislot
class".
Hence, we need to add 1 to the decoded value to match our data
structures.

Change-Id: Id3b121272bb7e84c0542ae9b4ce09598c6054edd
---
M src/bts.cpp
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/30/18130/1

diff --git a/src/bts.cpp b/src/bts.cpp
index 8edde23..a43613e 100644
--- a/src/bts.cpp
+++ b/src/bts.cpp
@@ -676,7 +676,7 @@
 static inline uint16_t egprs_mslot_class_from_ra(uint16_t ra, bool is_11bit)
 {
 	if (is_11bit)
-		return (ra & 0x3e0) >> 5;
+		return ((ra & 0x3e0) >> 5) + 1;
 
 	/* set EGPRS multislot class to 0 for 8-bit RACH, since we don't know it yet */
 	return 0;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18130
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Id3b121272bb7e84c0542ae9b4ce09598c6054edd
Gerrit-Change-Number: 18130
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200508/bf44c36f/attachment.htm>