Change in libosmo-abis[master]: e1_input: Add VTY command to enable PCAP debug output

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Fri May 8 11:25:36 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/18114 )

Change subject: e1_input: Add VTY command to enable PCAP debug output
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.osmocom.org/c/libosmo-abis/+/18114/1/src/e1_input_vty.c 
File src/e1_input_vty.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/18114/1/src/e1_input_vty.c@249 
PS1, Line 249: 		vty_out(vty, "Failed to setup E1 pcap recording to %s.%s", argv[1], VTY_NEWLINE);
argv[0]


https://gerrit.osmocom.org/c/libosmo-abis/+/18114/1/src/e1_input_vty.c@254 
PS1, Line 254: 	pcap_filename = talloc_strdup(NULL, argv[0]);
We try not to allocated on NULL ctx. Can you try finding a talloc context available?


https://gerrit.osmocom.org/c/libosmo-abis/+/18114/1/src/e1_input_vty.c@267 
PS1, Line 267: 	e1_set_pcap_fd(-1);
Don't you need to close the previous fd?



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/18114
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I0b4251702aecd6721b9d63c320351ef6cb513454
Gerrit-Change-Number: 18114
Gerrit-PatchSet: 1
Gerrit-Owner: tnt <tnt at 246tNt.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 08 May 2020 11:25:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200508/492b25f2/attachment.htm>


More information about the gerrit-log mailing list