Change in osmo-bsc[master]: stats: Add counters for received BSSMAP messages.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Fri May 8 11:18:23 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18112 )

Change subject: stats: Add counters for received BSSMAP messages.
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/18112/1/src/osmo-bsc/osmo_bsc_bssap.c 
File src/osmo-bsc/osmo_bsc_bssap.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/18112/1/src/osmo-bsc/osmo_bsc_bssap.c@1021 
PS1, Line 1021: 		rate_ctr_inc(&msc->msc_ctrs->ctr[MSC_CTR_BSSMAP_NUM_RX_UDT_RESET_ACKNOWLEDGE]);
What about assigning long pointer dereference chain into a signle pointer and using it in all cases? It would certainly clean up a bit lots of long lines.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18112
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I3f08d71b58b4e8d6f61376d85c2051e194aa8e43
Gerrit-Change-Number: 18112
Gerrit-PatchSet: 1
Gerrit-Owner: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 08 May 2020 11:18:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200508/e1a611ab/attachment.htm>


More information about the gerrit-log mailing list