Change in osmo-trx[master]: prbs-tool: Don't require C99

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu May 7 21:56:53 UTC 2020


laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/18107 )


Change subject: prbs-tool: Don't require C99
......................................................................

prbs-tool: Don't require C99

from a Debian8 build:

[  256s] prbs-tool.c: In function 'apply_errors_prbs':
[  256s] prbs-tool.c:190:2: error: 'for' loop initial declarations are only allowed in C99 or C11 mode
[  256s]   for (int i = 0; i < sizeof(pchan->prbs_u)-4; i++) {
[  256s]   ^

Change-Id: I8541fce50405525efffb12210a269e0ab8a687ab
---
M utils/prbs-tool.c
1 file changed, 5 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/07/18107/1

diff --git a/utils/prbs-tool.c b/utils/prbs-tool.c
index 0211453..664dc98 100644
--- a/utils/prbs-tool.c
+++ b/utils/prbs-tool.c
@@ -187,7 +187,9 @@
 /* apply any intentional errors to the output of the PRBS sequence */
 static void apply_errors_prbs(struct pchan_data *pchan)
 {
-	for (int i = 0; i < sizeof(pchan->prbs_u)-4; i++) {
+	int i;
+
+	for (i = 0; i < sizeof(pchan->prbs_u)-4; i++) {
 		pchan->sim_flip_codec_bits.i++;
 		if (pchan->sim_flip_codec_bits.i == pchan->sim_flip_codec_bits.nth_bit) {
 			pchan->sim_flip_codec_bits.i = 0;
@@ -237,7 +239,8 @@
 		rc = gsm0503_tch_fr_encode(pchan->bursts, pchan->tch_data, GSM_FR_BYTES, 1);
 		OSMO_ASSERT(rc == 0);
 #if 0
-		for (int i = 0; i < sizeof(pchan->bursts); i += GSM_BURST_BITS)
+		int i;
+		for (i = 0; i < sizeof(pchan->bursts); i += GSM_BURST_BITS)
 			printf("\t%s\n", osmo_ubit_dump(pchan->bursts + i, GSM_BURST_BITS));
 
 		dec(pchan->bursts);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/18107
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I8541fce50405525efffb12210a269e0ab8a687ab
Gerrit-Change-Number: 18107
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200507/a16162ef/attachment.htm>


More information about the gerrit-log mailing list