Change in osmo-ttcn3-hacks[master]: PCU: fix TC_ta_rach_imm_ass(): properly match Timing Advance

[fixeria]

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18080 )

Change subject: PCU: fix TC_ta_rach_imm_ass(): properly match Timing Advance
......................................................................

PCU: fix TC_ta_rach_imm_ass(): properly match Timing Advance

This test case would not fail even in case of Timing Advance mismatch.

Change-Id: Ife86e5e0e39f0112b854ed9a13e9c6f3c49531c9
Signed-off-by: Vadim Yanitskiy <axilirator at gmail.com>
---
M pcu/PCU_Tests.ttcn
1 file changed, 5 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved



diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn
index e848ea6..a40819d 100644
--- a/pcu/PCU_Tests.ttcn
+++ b/pcu/PCU_Tests.ttcn
@@ -727,8 +727,11 @@
 		}
 
 		/* Make sure Timing Advance IE matches out expectations */
-		if (match(rr_msg, tr_IMM_TBF_ASS(dl := false, ta := ta))) {
-			setverdict(pass);
+		if (rr_msg.payload.imm_ass.timing_advance != ta) {
+			setverdict(fail, "Timing Advance mismatch: ",
+				   rr_msg.payload.imm_ass.timing_advance,
+				   " vs expected ", ta);
+			mtc.stop;
 		}
 	}
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18080
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ife86e5e0e39f0112b854ed9a13e9c6f3c49531c9
Gerrit-Change-Number: 18080
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200507/fead2b6b/attachment.htm>