Change in osmocom-bb[master]: mobile: implement 'loopback' TCH frame I/O handler

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Wed May 6 19:41:19 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/17381 )

Change subject: mobile: implement 'loopback' TCH frame I/O handler
......................................................................

mobile: implement 'loopback' TCH frame I/O handler

Use newly added audio / loopback config vty node to provide audio
loopback from mobile app. Only FR is supported for now.

Change-Id: Icd0b8d00c855db1a6ff5e35e10c8ff67b7ad5c83
---
M src/host/layer23/src/mobile/voice.c
1 file changed, 22 insertions(+), 7 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/host/layer23/src/mobile/voice.c b/src/host/layer23/src/mobile/voice.c
index 5106063..4aae8aa 100644
--- a/src/host/layer23/src/mobile/voice.c
+++ b/src/host/layer23/src/mobile/voice.c
@@ -36,18 +36,33 @@
 {
 	struct gsm_data_frame *mncc;
 
+	/* Drop the l1ctl_info_dl header */
+	msgb_pull_to_l2(msg);
+	/* push mncc header in front of data */
+	mncc = (struct gsm_data_frame *)
+		msgb_push(msg, sizeof(struct gsm_data_frame));
+	mncc->callref = ms->mncc_entity.ref;
+
+	/* FIXME: FR only! */
+	switch (ms->rrlayer.cd_now.mode) {
+	case GSM48_CMODE_SPEECH_V1:
+		mncc->msg_type = GSM_TCHF_FRAME;
+		break;
+	default:
+		/* TODO: print error message here */
+		goto exit_free;
+	}
+
+	/* send voice frame back, if appropriate */
+	if (ms->settings.audio.io_handler == AUDIO_IOH_LOOPBACK)
+		gsm_send_voice(ms, mncc);
+
 	/* distribute and then free */
 	if (ms->mncc_entity.mncc_recv && ms->mncc_entity.ref) {
-		/* Drop the l1ctl_info_dl header */
-		msgb_pull_to_l2(msg);
-		/* push mncc header in front of data */
-		mncc = (struct gsm_data_frame *)
-			msgb_push(msg, sizeof(struct gsm_data_frame));
-		mncc->msg_type = GSM_TCHF_FRAME;
-		mncc->callref =  ms->mncc_entity.ref;
 		ms->mncc_entity.mncc_recv(ms, mncc->msg_type, mncc);
 	}
 
+exit_free:
 	msgb_free(msg);
 	return 0;
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/17381
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Icd0b8d00c855db1a6ff5e35e10c8ff67b7ad5c83
Gerrit-Change-Number: 17381
Gerrit-PatchSet: 8
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200506/667b597e/attachment.htm>


More information about the gerrit-log mailing list